Updates for SmugMug API and RSS changes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also adds an example private.brs.example file for some dev key methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the channel source to properly communicate with the updated SmugMug API. The main issues appear to have been that API 1.2.x was replaced with API 1.3.x (which is technically deprecated but will be supported for 1-2 more years), all URLs are now HTTPS, and the image ID/image Key/photo URL construction changed.
I was unable to test it with a linked account, so there could still be complications with displaying albums.
I also repaired the Makefile to communicate with newer Roku software using HTTP Digest authentication & an environment variable for the password.
Unfortunately, I don't know if these changes will be sufficient to get it updated in the channel store. It looks like the code is using deprecated Brightscript components for slideshows, image lists, and poster lists. These all may need to be upgraded to use SceneGraph components, which should probably be a separate PR.