infra: fix null ptr access

Fix null ptr access Fixes: 8beb4d9 ("infra: destroy ports after logical interfaces") Signed-off-by: Christophe Fontaine <[email protected]>
christophefontaine · Jul 24, 2024 · c7fcf4b · c7fcf4b
1 parent b7f27e2
commit c7fcf4b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/modules/infra/control/iface.c b/modules/infra/control/iface.c
@@ -228,7 +228,7 @@ static void iface_fini(struct event_base *) {
 	// Destroy all virtual interface first before removing DPDK ports.
 	for (ifid = 0; ifid < MAX_IFACES; ifid++) {
 		iface = ifaces[ifid];
-		if (iface != NULL || iface->type_id != GR_IFACE_TYPE_PORT) {
+		if (iface != NULL && iface->type_id != GR_IFACE_TYPE_PORT) {
 			if (iface_destroy(ifid) < 0)
 				LOG(ERR, "iface_destroy: %s", strerror(errno));
 			ifaces[ifid] = NULL;