Skip to content

Commit

Permalink
Fix Javadoc for Quad constructors (#1603)
Browse files Browse the repository at this point in the history
* Fix Javadoc for Quad constructors

* Add links to PR for visualizations
  • Loading branch information
JustinTimeCuber authored Jul 18, 2023
1 parent 605d881 commit a77df36
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions chunky/src/java/se/llbit/chunky/model/QuadModel.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
@PluginApi
public abstract class QuadModel implements BlockModel {

// For some visualizations, see this PR: https://github.com/chunky-dev/chunky/pull/1603
public static final Quad FULL_BLOCK_NORTH_SIDE = new Quad(
new Vector3(1, 0, 0),
new Vector3(0, 0, 0),
Expand Down
12 changes: 8 additions & 4 deletions chunky/src/java/se/llbit/math/Quad.java
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,12 @@ public Quad(Quad other, Matrix3 t) {

/**
* Create a new single sided quad
* <br>
* For some visualizations, see this PR: <a href="https://github.com/chunky-dev/chunky/pull/1603">#1603</a>
*
* @param v0 Bottom left vector
* @param v1 Top right vector
* @param v2 Bottom right vector
* @param v1 Bottom right vector
* @param v2 Top left vector
* @param uv Minimum and maximum U/V texture coordinates (x0,y0 bottom left)
*/
public Quad(Vector3 v0, Vector3 v1, Vector3 v2, Vector4 uv) {
Expand All @@ -113,10 +115,12 @@ public Quad(Vector3 v0, Vector3 v1, Vector3 v2, Vector4 uv) {

/**
* Create new quad
* <br>
* For some visualizations, see this PR: <a href="https://github.com/chunky-dev/chunky/pull/1603">#1603</a>
*
* @param v0 Bottom left vector
* @param v1 Top right vector
* @param v2 Bottom right vector
* @param v1 Bottom right vector
* @param v2 Top left vector
* @param uv Minimum and maximum U/V texture coordinates (x0,y0 bottom left)
* @param doubleSided True to make this quad double-sided
*/
Expand Down

0 comments on commit a77df36

Please sign in to comment.