Fix dimension bugs in the map view #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Does this need to be backported to 2.4? |
leMaik
approved these changes
Jul 19, 2023
|
Very likely, yes |
leMaik
added
backport-me
leMaik
pushed a commit
that referenced
this pull request
Jul 22, 2023
* Only draw player if they are in the current dimension * Update the map view immediately on switching dimensions
leMaik
removed
the
backport-me
leMaik
pushed a commit
to leMaik/chunky
that referenced
this pull request
Sep 9, 2023
* Only draw player if they are in the current dimension * Update the map view immediately on switching dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously players would always be rendered on the map view regardless of dimension.
Additionally, the map view wouldn't update on switching dimension and required the camera to move first