Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make container tests functional #57

Open
1 task
jsf9k opened this issue May 18, 2021 · 0 comments
Open
1 task

Make container tests functional #57

jsf9k opened this issue May 18, 2021 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented May 18, 2021

💡 Summary

In #54 I commented out most of the tests because the container as it stands does not support them. The container should be altered to support these tests, at which point they should be uncommented again.

Motivation and context

Containers should undergo some testing as a part of the CI process.

Acceptance criteria

  • All possible tests are supported by the container, and passing in GitHub Actions.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 18, 2021
jsf9k added a commit that referenced this issue May 18, 2021
@jsf9k
Comment out some tests
d0342b2 
The container doesn't currently support the functionality being
checked by the tests.  See #57 for more details.
@dav3r dav3r mentioned this issue May 19, 2021
Merged
9 tasks
jsf9k added a commit that referenced this issue May 20, 2021
@jsf9k
Merge pull request #57 from cisagov/improvement/insist-that-devs-own-…
2a2067f 
…gihub-dir

Ensure that the cisagov devs are the owners of the .github directory
cisagovbot pushed a commit that referenced this issue Jun 3, 2021
@mcdonnnj
Merge pull request #57 from cisagov/improvement/add_tag_script
a42ebe6 
Add the tag.sh Script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
BOD 18-01
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsf9k