Skeletonize #54
Merged
Skeletonize #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing env variable for test
…thon Set a default language for pre-commit hooks
…provement/upstream
Improvement/upstream
Add codeowners file with team OIS maintainers.
…provement/codeowners
Improvement/codeowners
Add isort configuration file.
Add isort tool to pre-commit hooks.
A user forked cisagov/scan-target-data and created a pull request, but the required GitHub Action(s) did not run. This is presumably because the user does not have Actions enabled in his or her fork. Ideally, the required Action(s) would run in cisagov/scan-target-data when a PR to merge changes back is created. Based on my reading of this link, adding the "pull_request" event type should make this happen: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
…m-forked-repos Make workflow run when a PR is opened, synchronized, or reopened
…ent/upstream-changes
Pull in upstream changes
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Update actions/checkout to v2 Update formatting to match downstream children
…n_and_checkout_action Update Python and actions/checkout Versions
Update pre-commit hooks (and flip Actions cache order in workflow).
…provements/pull_in_upstream_updates
… verbose '--requirement'.
…ches Use Verbose pip Switches
The container doesn't currently support the functionality being checked by the tests. See #57 for more details.
dav3r
reviewed
May 19, 2021
Co-authored-by: dav3r <[email protected]>
dav3r
reviewed
May 19, 2021
Co-authored-by: dav3r <[email protected]>
dav3r
reviewed
May 19, 2021
dav3r
reviewed
May 19, 2021
dav3r
approved these changes
May 19, 2021
Co-authored-by: dav3r <[email protected]>
mcdonnnj
approved these changes
May 20, 2021
Co-authored-by: Dave Redmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request skeletonizes this repo by pulling in the upstream changes from cisagov/skeleton-docker.
💭 Motivation and context
TravisCI is no longer free for open source and we have used up all our credits, so at a minimum this repo needed to be modified to use GitHub Actions. Since I was going to be doing that I figured I would go ahead and bring it into the light as well.
🧪 Testing
I built a new Docker image using these changes and verified that it continues to work as it did before.
✅ Checklist