Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev dependencies section #141

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add dev dependencies section #141

wants to merge 3 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 25, 2024 •
edited by dav3r
Loading

🗣 Description

This pull request adds a dev section to extras_require for type stub dependencies.

💭 Motivation and context

We want folks to be able to set up their development environment using setup.py.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Add types-docopt to mypy pre-commit hook additional dependencies
4d765d0 
This project uses the docopt library, so mypy needs this type
information.
@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 25, 2024
@jsf9k jsf9k mentioned this pull request Sep 25, 2024
Merged
11 tasks
@jsf9k jsf9k force-pushed the improvement/add-dev-dependencies branch from 8d0475a to 520fe1b Compare September 25, 2024 19:04
@jsf9k jsf9k force-pushed the improvement/add-dev-dependencies branch from 520fe1b to 6c2a022 Compare September 25, 2024 19:06
@jsf9k
Add a type: ignore hint to the end of the schema import line
b03458d 
No type stubs exist for the schema library.
@jsf9k jsf9k force-pushed the improvement/add-dev-dependencies branch from 92d9c39 to b03458d Compare September 25, 2024 19:20
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Sep 25, 2024
@jsf9k jsf9k marked this pull request as ready for review September 25, 2024 19:41
@dav3r dav3r requested a review from a team September 25, 2024 19:45
dav3r
dav3r approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release python Pull requests that update Python code
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @dv4harr10 @mcdonnnj