New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python < 3.8 compatibility #5

Merged

peay merged 1 commit into cisco-open:main from zach-b:py-compat

Nov 8, 2023

Contributor

zach-b commented Nov 8, 2023

Description

The lru_cache decorator must be explicitly called for python versions < 3.8 (@lru_cache() must be used instead of @lru_cache)

See https://docs.python.org/3/library/functools.html#functools.lru_cache

Changed in version 3.8: Added the user_function option.

Type of Change

Bug Fix

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass


          Fix python < 3.8 compatibility

ac2b2ec

zach-b requested a review from a team as a code owner

November 8, 2023 15:44

Contributor

peay commented Nov 8, 2023

LGTM, thanks!

peay approved these changes

View reviewed changes

peay merged commit 750bfe6 into cisco-open:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet