Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iMAP test list #1411

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Update iMAP test list #1411

merged 6 commits into from
Jan 15, 2024

Conversation

sitinurliza95
Copy link
Contributor

No description provided.

@sitinurliza95
Copy link
Contributor Author

Added https://sokong.org/ to my.csv

@sloncocs
Copy link
Collaborator

hi @sitinurliza95! Thanks for the contribution!

Could you please clarify why did you change https://www.malaysia-today.net to https://malaysia-today.net? For me the former redirects to www.malaysia-today.net

Same way, https://samudera.my/and https://agendadaily.com/ redirect to https://www.samudera.my/ and https://www.agendadaily.com/, so I would suggest changing them to www domains

@sitinurliza95
Copy link
Contributor Author

Hi @sloncocs the reason is because some ISPs in Malaysia only block them without "www" and would leave the links with "www" unblocked

@sloncocs
Copy link
Collaborator

@sitinurliza95 oh, thanks for this clarification, it's very important! could we please include both of them (www version and domain without www) in the list?

@sitinurliza95
Copy link
Contributor Author

I think that's up to you/Citizenlab but wouldn't it make the list a little too long? In general, ISPs that do block the "www" version would also block the ones without "www", hence why I kept only the versions without.

@sitinurliza95 sitinurliza95 mentioned this pull request Dec 19, 2023
@sloncocs sloncocs merged commit 684e1fd into citizenlab:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants