Skip to content

Commit

Permalink
switch to node test runner
Browse files Browse the repository at this point in the history
  • Loading branch information
dangowans committed Oct 4, 2024
1 parent cbc4c4a commit fda6582
Show file tree
Hide file tree
Showing 10 changed files with 326 additions and 152 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Install Application
run: |
npm ci
npm install -g mocha c8
npm install -g c8
- name: Run Coverage Testing
run: npm run coverage
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import browserLauncher from '@httptoolkit/browser-launcher';
import { parseVersion } from './utilities.js';
const installedWebBrowsersExpiryMillis = 5 * 60_000;
let installedWebBrowsers = [];
let installedWebBrowsersMillis = 0;
const installedWebBrowsersExpiryMillis = 5 * 60_000;
export const possibleWebBrowserTypes = [
'chrome',
'chromium',
Expand Down
4 changes: 3 additions & 1 deletion index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ import { type ApplicationVersion, parseVersion } from './utilities.js'

export type InstalledWebBrowser = browserLauncher.Browser & ApplicationVersion

const installedWebBrowsersExpiryMillis = 5 * 60_000

let installedWebBrowsers: InstalledWebBrowser[] = []
let installedWebBrowsersMillis = 0
const installedWebBrowsersExpiryMillis = 5 * 60_000

export const possibleWebBrowserTypes = [
'chrome',
Expand Down Expand Up @@ -53,6 +54,7 @@ async function _loadInstalledWebBrowsers(): Promise<InstalledWebBrowser[]> {
})
}

// eslint-disable-next-line write-good-comments/write-good-comments
/**
* Retrieves a list of installed web browsers that optionally match the given types.
* @param webBrowserTypes - An optional web browser type or list of web browser types to filter by.
Expand Down
Loading

0 comments on commit fda6582

Please sign in to comment.