Minor v4.1.0 azurerm bugfixes

[jcma-google]

Description

• providers need to include subscription id. This error didn't appear during my testing of the 4.1.0 update because it only occurs when the deployment setup changes.
• change private-ip allocation method to "Static"
  • the staging resource uses a standard SKU and "dynamic" allocation is only permissible for more expensive plans. It looks like "Static" just reserves an IP address and doesn't change it, not that I see a reason to change it after it's allocated.
• remove DOCKER_REGISTRY_SERVER_URL
  • this is now deprecated. The now preferred way of doing it is to set it in the linux_web_app resource, which we are already doing.
    allocation_method = "Static"

Checklist

General

• [x ] Added the correct label
• [x ] Assigned to a specific person or civiform/deployment-system
• [x ] Created tests which fail without the change (if possible)
• [x ] Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)
• [ x] Extended the README / documentation, if necessary

[gwendolyngoetz]

(question) Is there a reason not to get this from a terraform variable and the civiform*config.sh file. I'm concerned this will get forgotten about and cause issues down the road.

[jcma-google]

I tried using the config variable here and it works! I didn't realize that the providers.tf could access the variables but on retrospect it makes a lot of sense.

[jcma-google]

Wait actually it was because I forgot to push my changes

[jcma-google]

Okay it looks like the providers.tf doesn't have access to the civiform config, but maybe I'm missing something?