Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#68] Add FontAwesome 4 icon names #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

torfsen
Copy link
Contributor

@torfsen torfsen commented Oct 2, 2017

Fixes #68.

Some FA 4 icon names had already been added in #51, but others were missed.

Some FA 4 icon names had already been added in #51, but others were
missed.
@torfsen
Copy link
Contributor Author

torfsen commented Oct 2, 2017

CC @mattfullerton (#51 makes me doubt my skills as a code reviewer 😂)

@torfsen
Copy link
Contributor Author

torfsen commented Jan 24, 2018

@mattfullerton, could you take a look at this? Thanks!

@mattfullerton
Copy link
Contributor

I've taken a look: I think "delete" no longer works in FA4 so it also needs a mapping?
http://fontawesome.io/icons/

"file" should still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants