-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.641 fails to build using macOS native tools #193
Comments
cc @ckolivas |
The issue is that the |
I've done some more tinkering in Homebrew/homebrew-core#85360. #204 does fix the build, but not because it changes The issue is in the Interestingly, removing the compilation unit does not preclude optimized ASM features from being added:
Perhaps of concern on macOS is that the assembler is creating an |
ASM is unnecessary just for CRC. I should not have bothered putting it back in. In the LZMA SDK 18.00+ there is an ASM Decompressor which is blazingly fast. There I did take the time to convert the code to NASM.. In SDK 21.03beta there is also an LZFind assembler module which does match finding much faster too. X86_64 only. Some additional work on |
It looks like it is now making an empty archive (liblzmaasm) - which Apple's version of ar does not support doing.
See: Homebrew/homebrew-core#71422 for more log output
The text was updated successfully, but these errors were encountered: