Variable cells #1499
Merged
Variable cells #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit cleaner, and also paves the way for non-symbols having bindings (i.e., variable cells).
Besides the benefits with first class environments and etc., this saves 32 bits from symbols that aren't bound (the _BindingIdx).
This is necessary to let them signal unbound errors without needing a provided name. Also for printing nicely.
ALso work more directly with the TL indices in the compiled code. Little microoptimization to save a lookup.
Symbols should have had cleanup for the same reason - reusing TL indices - but don't seem to have for quite some time. It's probably not that important in practice since symbols/cells are hardly ever gonna be garbage collected, but we might as well try to get it right.
Used by Cando. It's fine I guess. Should really be changed to a proper setf though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I just did #1496 might as well knock this one out too. Stores dynamic variable values in cells rather than straight in the symbols. Bla bla bla separation of concerns is good, and this will make first class environments easier.