Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve printing of quasiquote #1503

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Improve printing of quasiquote #1503

merged 3 commits into from
Oct 1, 2023

Conversation

yitzchak
Copy link
Member

No description provided.

@yitzchak yitzchak marked this pull request as ready for review October 1, 2023 13:20
Bike
Bike requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@Bike Bike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the stuff I mentioned I think this looks good.

src/core/write_list.cc Show resolved Hide resolved
src/lisp/kernel/lsp/pprint.lisp Show resolved Hide resolved
@yitzchak yitzchak merged commit 8b03dd2 into main Oct 1, 2023
8 checks passed
@yitzchak yitzchak deleted the print-quasiquote branch October 1, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bike Bike Bike requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yitzchak @Bike