Remove typeq #1510
Merged
Remove typeq #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving away from compiler macros and inlining so things work better with bytecode.
Not integrated with the atomics though. Hoping to use this for headerq.
HEADERP is like a functional version of most of TYPEQ - you can use it to check the "header class" of a general object. clasp-cleavir doesn't yet optimize HEADERP calls.
This should put us basically where we were with typep before, except without needing the typeq special operator.
ideally this primop would be removed in favor of vref, and ditto aset, but that'll take a bit more sophistication in rewriting.
Removes some duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typeq special operator is the main remaining messy point we have to worry about in the compiler. It works poorly with the bytecode, adds a complication to code walking, yada yada yada.
This PR leaves (most) things as typep calls but puts in optimizations clasp-cleavir can use to replace those calls with header checks &c. like we have. It also improves clasp-cleavir type inference a bit with information about predicate functions like
consp.