Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to Cortana and Google Home #116

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carloseduardole
Copy link

@carloseduardole carloseduardole commented May 2, 2018

Hello,

I would like to contribute with a plugin for Cortana and Google Home.

This implementation relies on the 3rd party libs distributed by Cortana and google to their assistants.

@stojanovic
Copy link
Member

Awesome, I'll take a look at it!

We still try to be compatible with Node v4 (which is probably not that important anymore, but I need to discuss support with other team members), and the tests are failing because you used:

const { ActionsSdkApp } = require('actions-on-google');

As this is a simple change, can you make sure it works on node 4, too?

@stojanovic stojanovic self-assigned this May 3, 2018
@carloseduardole
Copy link
Author

@stojanovic, I was doing some tests with node 4 yesterday, and the problem is that actions-on-google support just node 6+.

"engines": { "node": ">=6.0.0" },

So it will be hard to add support to node 4.

@carloseduardole
Copy link
Author

@gojko
Copy link
Member

gojko commented May 24, 2018

I planned to clean up some code in claudia anyway when 4 goes away, but until it's fully gone in end of july, we should support it with claudia tools.

I suggest we use a major version (eg 5) and drop node4 support from it. then this gets integrated only into v5. people who are still on node4 can use claudia v4/claudia bot builder v4

@gojko
Copy link
Member

gojko commented Jun 7, 2018

I've pushed claudia 5.x to NPM, which now assumes Node 6 as the baseline, so we can unblock this finally. Things that are only supported in 6 can now go into the main toolkit.

@acucciniello
Copy link

any update when this will be complete? I am looking to use the bot builder for a multitude of bots! including alexa and google home

@carloseduardole
Copy link
Author

I will try to update this branch with the latest changes from claudia-bot-builder this week to see if the problem with Node Version is solved.

@carloseduardole
Copy link
Author

Ok, commit rebased with the master. Waiting on the review now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants