WIP: Fix how qinit_type==4 is handled: should be perturbation to eta from qinit #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to update to handle case when original eta is not just sea_level=0, and also make more consistent with other types so it perturbs eta only in wet cells, not in ones set to dry in qinit.
|
Now I think the original code is correct, see #504. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to update to handle case when original eta set in qinit is not just sea_level=0,
and also make more consistent with other types, so it perturbs eta only in wet cells, not in ones set to dry in qinit.
This implements my suggestion in #504.
Don't merge yet since there might be some discussion of this.
Also, @mandli should take a look at the multilayer case and see if we want to make a similar change there.