Test simple Plonk circuit on all curves #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vesselinux
force-pushed
the
103-plonk-simple-circuit-all-curves
branch
2 times, most recently
from
ecac2a5
to
71bfd8a
Compare
…d unit tests for the simple quadratic residue circuit for all curves (addresses issue #103)
vesselinux
force-pushed
the
103-plonk-simple-circuit-all-curves
branch
from
71bfd8a
to
be86180
Compare
dtebbs
suggested changes
Feb 3, 2023
libsnark/zk_proof_systems/plonk/tests/dummy_transcript_hasher.hpp
Outdated
Show resolved
Hide resolved
libsnark/zk_proof_systems/plonk/tests/dummy_transcript_hasher.tcc
Outdated
Show resolved
Hide resolved
libsnark/zk_proof_systems/plonk/tests/dummy_transcript_hasher.hpp
Outdated
Show resolved
Hide resolved
libsnark/zk_proof_systems/plonk/tests/dummy_transcript_hasher.hpp
Outdated
Show resolved
Hide resolved
…thod buffer_clear to reset (#107 (comment)); minor edits in comments (#107 (comment)).
|
@vesselinux I think this needs rebasing onto the destination branch. |
Hmm, I am running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for the simple quadratic residue circuit for all curves. Addresses issue #103, except the Edwards and BN128 curves (issue #108).