Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zeth submodule [mimc-selector] #100

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update zeth submodule [mimc-selector] #100

wants to merge 1 commit into from

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Apr 1, 2022

Update to zeth commit which cleans up mimc selection (selecting mimc params based on the scalar field). Removed unused components from zecale.

@dtebbs dtebbs changed the title Update zeth submodule [mimc-selector] [WIP] Update zeth submodule [mimc-selector] Apr 1, 2022
@dtebbs dtebbs marked this pull request as ready for review April 1, 2022 17:14
@dtebbs dtebbs changed the title [WIP] Update zeth submodule [mimc-selector] Update zeth submodule [mimc-selector] Apr 1, 2022
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Apr 4, 2022

This PR also bumps the gRPC version to 1.32, which seems to address the old git:// submodule URLs which aren't supported anymore (as mentioned and done in clearmatics/zeth#423 (comment))

Note: waiting to get an answer to clearmatics/zeth#423 (comment) before merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants