Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests on CI #326

Merged
merged 18 commits into from
Feb 9, 2021
Merged

Integration tests on CI #326

merged 18 commits into from
Feb 9, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Dec 8, 2020

  • Use github actions caching to speed up jobs
  • Build linux natively (using caching)
  • Launch prover server and run tests that depend on it

@dtebbs dtebbs removed the request for review from AntoineRondelet December 8, 2020 17:18
@dtebbs
Copy link
Contributor Author

dtebbs commented Dec 9, 2020

Potential cache of submodule builds:

  1. get-submodule-commits job extract commits of submodules and outputs as variables
  2. build job caches the build for each submodule using a key containing the commit

@AntoineRondelet
Copy link
Contributor

@dtebbs is this one still WIP, or shall it be rebased on top of develop and reviewed?

@AntoineRondelet
Copy link
Contributor

I can see that many changes in this PR are not strictly related to caching things on the CI (type parameter renaming, changes in the MiMC gadgets etc) - in fact it looks like CI changes are in minority in this PR.
Let's stick as closely as possible to the "one PR = one thing" in the future, otherwise this is hard to track down what exact changes are brought in by which PR (and makes the releases notes harder to write)

@dtebbs
Copy link
Contributor Author

dtebbs commented Jan 6, 2021

@dtebbs is this one still WIP, or shall it be rebased on top of develop and reviewed?

It's still WIP. I was looking at caching the submodule builds (which is a bit more involved than the caching in #341), and apparently there is a possibility that Aleksandr will look at this, so it's shelved for now.

I can see that many changes in this PR are not strictly related to caching things on the CI (type parameter renaming, changes in the MiMC gadgets etc) - in fact it looks like CI changes are in minority in this PR.
Let's stick as closely as possible to the "one PR = one thing" in the future, otherwise this is hard to track down what exact changes are brought in by which PR (and makes the releases notes harder to write)

No intention of doing multiple things - this probably just needs rebasing.

@AntoineRondelet
Copy link
Contributor

I was looking at caching the submodule builds (which is a bit more involved than the caching in #341), and apparently there is a possibility that Aleksandr will look at this, so it's shelved for now.

Got it, thanks

No intention of doing multiple things - this probably just needs rebasing.

Ah, right!

@dtebbs dtebbs added the frozen Activity on this PR is temporarily stopped. Please do not push to this PR label Jan 6, 2021
@dtebbs dtebbs force-pushed the ci-cache-test branch 10 times, most recently from c8f0bb0 to 4ffc29d Compare January 22, 2021 19:33
@dtebbs dtebbs force-pushed the ci-cache-test branch 2 times, most recently from e9e5b12 to 8d693e5 Compare January 29, 2021 17:34
@dtebbs dtebbs added ci Task related to the Continuous Integration (configuration, service etc.) and removed frozen Activity on this PR is temporarily stopped. Please do not push to this PR labels Feb 1, 2021
@dtebbs dtebbs changed the title [WIP] CI cache test CI cache test Feb 1, 2021
@dtebbs dtebbs changed the title CI cache test Integration tests on CI Feb 1, 2021
.github/workflows/onpush-build-macos.yml Outdated Show resolved Hide resolved
.github/workflows/onpush-build-ubuntu.yml Outdated Show resolved Hide resolved
.github/workflows/onpush-build-ubuntu.yml Outdated Show resolved Hide resolved
depends/CMakeLists.txt Outdated Show resolved Hide resolved
scripts/install_grpc Outdated Show resolved Hide resolved
scripts/install_grpc Outdated Show resolved Hide resolved
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good to have more tests on the CI, thanks @dtebbs

@AntoineRondelet AntoineRondelet merged commit 42ffe31 into develop Feb 9, 2021
@AntoineRondelet AntoineRondelet deleted the ci-cache-test branch February 19, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Task related to the Continuous Integration (configuration, service etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants