-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests on CI #326
Conversation
dtebbs
commented
Dec 8, 2020
•
edited
Loading
edited
- Use github actions caching to speed up jobs
- Build linux natively (using caching)
- Launch prover server and run tests that depend on it
Potential cache of submodule builds:
|
@dtebbs is this one still WIP, or shall it be rebased on top of develop and reviewed? |
I can see that many changes in this PR are not strictly related to caching things on the CI (type parameter renaming, changes in the MiMC gadgets etc) - in fact it looks like CI changes are in minority in this PR. |
It's still WIP. I was looking at caching the submodule builds (which is a bit more involved than the caching in #341), and apparently there is a possibility that Aleksandr will look at this, so it's shelved for now.
No intention of doing multiple things - this probably just needs rebasing. |
Got it, thanks
Ah, right! |
c8f0bb0
to
4ffc29d
Compare
e9e5b12
to
8d693e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - good to have more tests on the CI, thanks @dtebbs