Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update precommit hooks #60

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Update precommit hooks #60

merged 3 commits into from
Jul 29, 2024

Conversation

ulgens
Copy link
Contributor

@ulgens ulgens commented Jul 24, 2024 •
edited
Loading

  • pre-commit-hooks: from 4.4.0 to 4.6.0

@espdev
Copy link
Member

espdev commented Jul 24, 2024

I think we can use ruff for all (and code formatting also) instead of isort+yapf:

ruff format . && ruff check --fix .

One tool is better than 3 :)

@ulgens
Copy link
Contributor Author

ulgens commented Jul 24, 2024 •
edited
Loading

I'm +1 for that. I can handle it in the PR or create a new one. Which one sounds better? - creating a new one.

@espdev
Copy link
Member

espdev commented Jul 24, 2024

I think create a new one is better.

@ulgens
Remove yapf
f314580 
All formatting & linting will be handled by ruff
@ulgens ulgens mentioned this pull request Jul 28, 2024
Merged
@ulgens ulgens marked this pull request as draft July 28, 2024 07:59
@espdev espdev marked this pull request as ready for review July 29, 2024 20:56
@espdev espdev merged commit 3523e28 into click-contrib:master Jul 29, 2024
18 checks passed
@ulgens ulgens deleted the update_precommit_hooks branch July 30, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulgens @espdev