fix(docblocks): Mitigate issue in ide-helper docblock parsing #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation code has some issues with imported class names in docblocks. It does not resolve those properly and thus leads to incorrect annotations. This was mitigated by transforming all current macro annotations to use the fully qualified class names See barryvdh/laravel-ide-helper#953 Before this PR: ```php /** * * * @param array|string|\MagellanBaseExpression $groups * @return static * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy() * @static */ public static function stGroupBy(...$groups) { return \Illuminate\Database\Query\Builder::stGroupBy(...$groups); } ``` After: ```php /** * * * @param array|string|\Clickbar\Magellan\Database\MagellanExpressions\MagellanBaseExpression $groups * @return static * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy() * @static */ public static function stGroupBy(...$groups) { return \Illuminate\Database\Query\Builder::stGroupBy(...$groups); } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation code has some issues with imported class names in docblocks. It does not resolve those properly and thus leads to incorrect annotations. This was mitigated by transforming all current macro annotations to use the fully qualified class names
See barryvdh/laravel-ide-helper#953
Before this PR:
After: