Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Node.js v16 as minimum #70

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

ngbrown
Copy link
Contributor

@ngbrown ngbrown commented Jul 20, 2023

Blocks #68 and #71

This bumps the minimum version of Node.js to v16. This is a breaking change and requires a major version increment.

Node.js v20 was included in the test matrix

Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, hopefully rest of the team agrees with this, will merge as soon as I have some indication about that :)

@dentarg dentarg merged commit ee35d75 into cloudamqp:main Jul 21, 2023
3 checks passed
@ngbrown ngbrown deleted the feature/node-v16-as-minimum branch July 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants