Add client close timeout on term #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Sep 26, 2024
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
|
From what i gather from #170 was that they wanted TERM to basically start a timer, and never shutdown regardless if the server already had connections or not. |
spuun
force-pushed
the
client-close-on-shutdown-timeout
branch
from
8b8b23b
to
f9a42c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a second shutdown timeout to wait for clients to send Close before sending Close to the clients.
Fixes #170