Refactor Reporter to not know about implementations #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
The
Reporter
class is an odd bird and only used for debugging purposes. It knows too much about classes (even accessing instance variables) which prevents refactoring.This PR refactors
Reporter
to not know anything about any implementation; instead "reportable" entities must include theReportable
module and specify their reportable objects with thereportables
macro.The macro may look scary at a first glance, but it will generate a
__report
method that will report all specified "reportables" to theReporter
instance. This makes theReporter
only responsible for the output, while each entity is responsible for what to report.HOW can this pull request be tested?
Run lavinmq and send
USR1
to observe output.