Minion pooling optimizations #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch will make sure that getting minion pool events and progress updates will only occur when actually printing them out to the UI or CLI, and excluding them otherwise.
When multiple `joinedload`s were queried, it resulted in a cartesian product list of rows. Switching to `selectinload`, while performing multiple queries to the DB server, will make sure that the minimum amount of rows get returned from the DB. This fixes hangups when fetching progress updates and events of long-running minion pools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fetch minion pool events and progress updates when actually needed
This patch will make sure that getting minion pool events and progress updates
will only occur when actually printing them out to the UI or CLI, and
excluding them otherwise.
Fix cartesian product on minion pool fetching
When multiple
joinedloads were queried, it resulted in a cartesian productlist of rows. Switching to
selectinload, while performing multiple queriesto the DB server, will make sure that the minimum amount of rows get returned
from the DB. This fixes hangups when fetching progress updates and events of
long-running minion pools.