Replace time.Time.String() with time.Time.Format() #1017
Conversation
.github/workflows/draft-release.yaml
Outdated
| @@ -6,6 +6,7 @@ on: | |||
| - 'protocol/**' # Push events to matching protocol/foo/bar/v*, i.e. protocol/foo/bar/v1.0, protocol/foo/bar/v20.15.10 | |||
| - 'observability/**' # Push events to matching observability/foo/bar/v* | |||
| - 'sql/**' # Push events to matching sql/v* | |||
| - 'binding/**' # Push events to matching binding/foo/bar/v* | |||
README.md
Outdated
| @@ -27,7 +27,7 @@ _Note:_ Supported go version: 1.14+ | |||
| Add the module as dependency using go mod: | |||
|
|
|||
| ```shell | |||
| go get github.com/cloudevents/sdk-go/v2@v2.4.1 | |||
| go get github.com/cloudevents/sdk-go/v2@v2.5.0 | |||
There was a problem hiding this comment.
nit: should be separate PR (incl. the other ones)
| /* | ||
| Copyright 2021 The CloudEvents Authors | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
| stream.WriteString(eventContext.Time.String()) | ||
| stream.WriteString(eventContext.Time.Format(time.RFC3339)) |
There was a problem hiding this comment.
I ran an example w/ Go 1.22 (same w/ Go 1.21) here: https://go.dev/play/p/NcMTqPu75fe
And I get:
2009-11-10 23:00:00 +0000 UTC m=+0.000000001
2009-11-10T23:00:00Z
Which could be considered a breaking change. WDYT?
cc/ @duglin
There was a problem hiding this comment.
I'm ok with the breaking change. I'm more bothered that:
1 - it wasn't spec compliant before and no one noticed
2 - not a single testcase needed to be changed
I agree with splitting the upgrade stuff into a separate PR. But can we also get at least one testcase added that checks the format of the time attribute and that it adheres to the CE spec (RFC3339) ?
There was a problem hiding this comment.
I'll get to work on it! Thank you so much for the feedback!
There was a problem hiding this comment.
Cleaned up the PR. Currently working on test cases:)
MaryamTaj
force-pushed
the
issue-987
branch
2 times, most recently
from
a209c30
to
232dcc4
Compare
Signed-off-by: MaryamTaj <[email protected]>
Signed-off-by: MaryamTaj <[email protected]>
Signed-off-by: MaryamTaj <[email protected]>
|
@MaryamTaj converted to draft, seems you're still working on this. Once ready for review, please just mark as "Ready for review" and ping us. |
|
@MaryamTaj any update on this? |
|
@duglin Hi Doug! I was running into some issues earlier, where all the tests pass locally but not on GitHub. I am going to try a new approach, and I'll let you know how it goes |
|
ok thanks for the update. |
|
@MaryamTaj any update on this? |
Signed-off-by: MaryamTaj <[email protected]>
Signed-off-by: MaryamTaj <[email protected]>
|
@duglin I think I'm running into a wall. I tried to resolve as many errors as I could. |
Resolves #987
Earlier, we used time.Time.String() to marshal time into a string. According to the go time.Time documentation however, time.Time.String() is only suitable for debugging purposes. This PR replaces time.Time.String with time.Time.Format() with RFC3339 to provide a stable serialized representation of time.