Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue size configurable & drop oldest packets first #405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

copy
Copy link

@copy copy commented Apr 23, 2024

This PR contains three commits:

  1. Make the queue size configurable. In my program, the server sometime starts on-demand, and the client buffers a significant number of packets by default, which causes a bit of flooding
  2. Replaces a conditional with an assertion. I'd happily revert if this desired by maintainers. This code would probably be a bit more readable if dequeue_packet and requeue_packet were inlined into their callsite, which I'd also happily contribute
  3. Drop oldest packets first. I believe this is reasonable (think TCP retransmits), but I'd be happy to keep the current behaviour if wanted

Side-note: Is there a way to run only tests that don't required sudo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant