Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect custom x509 ext in selfsign #1281

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

sthussey
Copy link
Contributor

@sthussey sthussey commented Apr 7, 2023

  • No longer ignore specified x509 extensions in the CSR when generating a self-signed certificate.

- No longer ignore specified x509 extensions in the CSR
  when generating a self-signed certificate.
@sthussey
Copy link
Contributor Author

sthussey commented Apr 7, 2023

This resolves issue #1280

@nickysemenza
Copy link
Member

this looks good; is there a simple test you could add for this?

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4d0d87) 52.94% compared to head (f7af124) 52.94%.
Report is 102 commits behind head on master.

❗ Current head f7af124 differs from pull request most recent head 5ac7cd9. Consider uploading reports for the commit 5ac7cd9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   52.94%   52.94%           
=======================================
  Files          76       76           
  Lines        9095     9096    +1     
=======================================
+ Hits         4815     4816    +1     
  Misses       3813     3813           
  Partials      467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sthussey
Copy link
Contributor Author

@nickysemenza Sorry for the long delay, lost track of this. I've added a test.

  - Test that a CSR custom OID extension is correctly included
    in the resulting certificate
@nickysemenza nickysemenza merged commit 02d4045 into cloudflare:master Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants