Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where federation with Pleroma would result in 400 "Invalid signature"
Here's what Pleroma sees:
Notice
(created)
being blank.Unfortunately, Pleroma only supports the
(request-target)
(and@request-target
) pseudo-headers. This is not on purpose, it's a bug in the http_signatures library used to verify requests.I don't think it's especially important to sign the
(created)
header when a Digest is available, so the best course of action is to remove it.(P.S. I'm maintaining a Deno library with Wildebeest's HTTP signature code here: https://gitlab.com/soapbox-pub/fedisign )