ID Device path resolver #343
Open
+53
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonskie
requested review from
a team,
anshrupani and
klakin-pivotal
and removed request for
a team
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we noticed that the id device path resolver code path always did a fallback to other mechanisms to mount the disk.
and this was due to the fact that the
DiskIDprovided by the agent never matched the actual disk.with this change you can now add regex patterns and replacements in the agent.json to match the expected disk-id
for example AWS:
provides the disk id as
vol-04b2a40747d7e9625but the actuall disk path is/dev/disks/by-id/nvme-Amazon_Elastic_Block_Store_vol04b2a40747d7e9625and if we place the following in the agent.json
it would be transformed to
vme-Amazon_Elastic_Block_Store_vol04b2a40747d7e9625