Improve draining of delayed worker #3999
Open
+256
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Haass <[email protected]>
Co-authored-by: Johannes Haass <[email protected]>
Rake task 'jobs:clear_locks_for_current_worker[worker_name]' allows operators to clear all locks for a given worker in the delayed jobs table. Could be also used in a drain script to ensure that there are no pending jobs.
This change allows operators to set the number of threads to start multiple delayed worker threads (ThreadedWorker). Additionally the grace period can be configured after which the threads will be killed. Both are implemented as parameters in the jobs rake task. The existing `number_of_worker_threads` in the api and worker schema was removed.
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the draining behavior of the delayed workers:
shutdown_delayed_workermethod toDrainclass which configurable timeoutjobs:clear_pending_locksrake task to clear pending job locks in the delayed jobs table for the given worker.Additionally it allows operators to set the number of delayed worker threads and the grace period after which threads will be killed via the jobs rake task.
Changes will be integrated into capi release with a follow up PR.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests