Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select ICMP version for common ICMP rules #1713

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: select ICMP version for common ICMP rules #1713

merged 3 commits into from
Aug 6, 2024
+16 −6

Commits on Aug 6, 2024

  1. fix: select ICMP version for common ICMP rules 

    This fixes kube-router trying to use `icmp` instead of `icmpv6` when creating common ICMP rules with ip6tables.

Fixes: #1712
    @qbnit
    qbnit committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8dfb572 View commit details
    Browse the repository at this point in the history

  2. test: update utils/iptables_test to align with recent fix 

    Update tests for code affected in 8dfb572.
    @qbnit
    qbnit committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9ac0e45 View commit details
    Browse the repository at this point in the history

  3. fix(util): syntax in iptables.go 

    Fix strange mistake with ';' instead of 'string'.
    @qbnit
    qbnit committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ab9e6b0 View commit details
    Browse the repository at this point in the history