Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues with refactors #1755

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Conversation

aauren
Copy link
Collaborator

@aauren aauren commented Oct 20, 2024

@mrueg @twz123 @rbrtbnfgl

Fixes a couple of things:

  • During one of the recent refactors, we lost the fact that the router-id for BGP should default to the IPv4 address when it isn't otherwise specified
  • Fixes a potential for the IP addresses on nodes to not obey the ordering of internal first then external. This mostly impacted tests, but would have eventually impacted users as well once a release was createdc
  • Removes a potential race condition from LoadBalancerAllocator tests
  • Reduces the total unit test run times by setting t.Parrallel() on ecmp_vip_test.go which was the longest test in the suite
    • It would be nice to set this on more tests in the routing suite, but unfortunately, we can't use it any time we actually start a gobgp server because it has several global vars that introduce race conditions and testing irregularity
  • Minor fixes:
    • Adds a python script which parses Go unit tests, which is helpful for understanding which tests in the suite take the longest
    • Fixes import definition order in linux_networking_moq.go
    • Updates makefile to run goimports as well as gofmt when gofmt-fix target is executed

Somehow during refactoring this default got lost and we stopped
defaulting to the primary IPv4 address when a router ID was not passed.
Adds a Python script that is useful for seeing where very slow unit
tests can be found and fixed.
We should be returning IP addresses in specific orders based upon what
type of IP they are.
@aauren aauren merged commit 8bb7cbf into master Oct 21, 2024
7 checks passed
@aauren aauren deleted the fix_various_issues_with_refactors branch October 21, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants