Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dsr): change grpc resolver to passthrough #1756

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(dsr): change grpc resolver to passthrough #1756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/cri/remote_runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ func NewRemoteRuntimeService(endpoint string, connectionTimeout time.Duration) (

klog.V(4).Infof("[RuntimeService] got endpoint %s (proto=%s, path=%s)", endpoint, proto, addr)

if proto != "unix" {
if proto == "unix" {
// Every since grpc.DialContext was deprecated, we no longer get the passthrough resolver for free, so we need
// to add it manually. See: https://github.com/grpc/grpc-go/issues/1846 for more context
addr = "passthrough:///" + addr
} else {
return nil, errors.New("[RuntimeService] only unix socket is currently supported")
}

Expand Down