Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform cloudposse/ecs-container-definition/aws to v0.61.1 (main) #244

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 2, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/ecs-container-definition/aws (source) module minor 0.58.1 -> 0.61.1

Release Notes

cloudposse/terraform-aws-ecs-container-definition (cloudposse/ecs-container-definition/aws)

v0.61.1

Compare Source

🚀 Enhancements
Fix: Duplicate name in portMapping fixed & Docs Updated @​Hackerbone (#​171)
what

The portMapping parameter had a duplicate name field occurrence

why

Failure in creating services in the new release v0.61.0

references

I was waiting for the previous PR to get merged since I use this module in my project for a while. Saw CI checks didn't pass so I made a new fix PR.

v0.61.0

Compare Source

chore: add service connect fields to portMapping @​dudymas (#​168)

what

  • added name and appProtocol to portMapping variables

why

  • Service Connect uses these fields

references

v0.60.1

Compare Source

fix: add port mapping name (#​162) @​aaronlake (#​166)

what

  • Add optional variable name to portMappings to allow Service Discovery registration

why

  • Unable to allow ECS container definitions to register with Service Discovery

references

🤖 Automatic Updates

Update README.md and docs @​cloudpossebot (#​167)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

v0.60.0

Compare Source

fix: strengthen types, simplify logic (#​154) @​goruha (#​164)

what

  • enable & use optional attributes where AWS API marks fields optional
  • remove redundant lookups
  • strengthen types for log_configuration, repository_credentials, system_controls, container_definition
  • reorder object var attributes to match AWS docs
  • simplify log configuration sanitization/munging
  • simplify secret & environment var sorting
  • expose unencoded container definition output directly without requiring pointless jsonencode/jsondecode cycle

why

  • optional obviates lookup(..., null) calls for objects
  • lookup(o, k) without a default is deprecated in favor of o[k] or direct attr access (o.k)
  • log_configuration, repository_credentials, and system_controls had needlessly opaque any types which hinder DX and make subtle bugs more likely (e.g. in the types of log_configuration.options values)
  • since all attributes of container_definition are now typed there's no reason not to type it as well
  • following the AWS documentation's field order makes types easier to verify for completeness & correctness
  • typing log_configuration appropriately obviates explicit tostring & null handling; resolves #​151
  • env/secret map sorting can be dramatically simplified since for-expressions iterate over maps & objects by key in lexicographic order
  • jsonencode-ing the final container definition only to jsondecode for json_map_object is redundant

Refs

  • #​154
  • @​obataku
Sync github @​max-lobur (#​161)

Sync github from the template

v0.59.0

Compare Source

  • No changes

v0.58.3

Compare Source

🚀 Enhancements

fix: eternal churn of environment variables @​kevcube (#​159)

what

  • Maybe the AWS container definition API changed but applying a container constructed from this module will post with environment = null which amazon translates to environment = []
  • So every subsequent apply will have changes in terraform like environment = [] ~> null

why

  • if we match what amazon translates to, then the terraform state stays consistent

v0.58.2

Compare Source

Remove unused provider @​pguinard-public-com (#​157)

what

  • Remove unused provider

why

references

git.io->cloudposse.tools update @​dylanbannon (#​152)

what and why

Change all references to git.io/build-harness into cloudposse.tools/build-harness, since git.io redirects will stop working on April 29th, 2022.

References

  • DEV-143

🤖 Automatic Updates

Update README.md and docs @​cloudpossebot (#​155)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the auto-update This PR was automatically generated label Mar 2, 2024
@renovate renovate bot requested review from a team as code owners March 2, 2024 19:48
@renovate renovate bot requested review from Gowiem and joe-niland March 2, 2024 19:48
@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@renovate renovate bot force-pushed the renovate/main-cloudposse-ecs-container-definition-aws-0.x branch from 4c61213 to 9497ab2 Compare March 2, 2024 23:28
Copy link
Contributor Author

renovate bot commented Mar 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@mergify mergify bot added the readme Improvements or additions to the README label Apr 1, 2024
Copy link

mergify bot commented Apr 1, 2024

/terratest

Copy link

mergify bot commented Apr 1, 2024

💥 This pull request now has conflicts. Could you fix it @renovate[bot]? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Apr 1, 2024
@mergify mergify bot closed this Apr 1, 2024
Copy link

mergify bot commented Apr 1, 2024

This automated PR was closed due to merge conflicts.

Copy link
Contributor Author

renovate bot commented Apr 1, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (0.61.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/main-cloudposse-ecs-container-definition-aws-0.x branch April 1, 2024 18:31
@mergify mergify bot removed readme Improvements or additions to the README conflict This PR has conflicts labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant