feat: Add JSON type schema #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Jul 17, 2024
erezrokah
commented
Jul 17, 2024
erezrokah
commented
Jul 17, 2024
erezrokah
commented
Jul 17, 2024
erezrokah
force-pushed
the
feat/add_json_type_schema
branch
from
d8d56c2
to
bc10bdb
Compare
erezrokah
commented
Jul 17, 2024
erezrokah
commented
Jul 17, 2024
|
Adding @marianogappa as a reviewer to this because I don't have the bandwidth to dive into this and give it the proper level of attention |
erezrokah
force-pushed
the
feat/add_json_type_schema
branch
from
dc8cd41
to
36ec297
Compare
erezrokah
commented
Jul 23, 2024
erezrokah
force-pushed
the
feat/add_json_type_schema
branch
from
8c9b343
to
927da7b
Compare
erezrokah
force-pushed
the
feat/add_json_type_schema
branch
from
927da7b
to
b664157
Compare
erezrokah
commented
Jul 23, 2024
| @@ -111,17 +118,11 @@ func (t *structTransformer) addColumnFromField(field reflect.StructField, parent | |||
| return nil | |||
| } | |||
|
|
|||
| columnType, err := t.typeTransformer(field) | |||
| columnType, err := t.getColumnType(field) | |||
There was a problem hiding this comment.
Extracted getColumnType to a dedicated function
|
Sorry for the review noise, I basically re-did the PR without using |
marianogappa
approved these changes
Jul 24, 2024
| @@ -46,6 +46,8 @@ type Column struct { | |||
|
|
|||
| // PrimaryKeyComponent is a flag that indicates if the column is used as part of the input to calculate the value of `_cq_id`. | |||
| PrimaryKeyComponent bool `json:"primary_key_component"` | |||
|
|
|||
| TypeSchema string `json:"type_schema,omitempty"` | |||
There was a problem hiding this comment.
All the other fields here have docs. I think a comment is warranted on this one too 🤔
marianogappa
approved these changes
Jul 24, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [4.52.0](v4.51.0...v4.52.0) (2024-07-24) ### Features * Add JSON type schema ([#1796](#1796)) ([dbc534b](dbc534b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jul 24, 2024
Closed
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
#### Summary I missed this in #1796. Actually added the `normalizePointer` for this reason just forgot to use it for map and slice pointers ---
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jul 24, 2024
#### Summary Part of #2023 ~~Needs cloudquery/cloudquery-api-go#196 and~~ cloudquery/plugin-sdk#1796 ~~Still WIP~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of cloudquery/cloudquery#2023
Still WIP and depends on cloudquery/cloudquery-api-go#196Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)