Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS lookups give values $VAL wrapped as "b'$VAL'" when using python 3 #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KMS lookups give values $VAL wrapped as "b'$VAL'" when using python 3 #762

wants to merge 1 commit into from

Conversation

baryal1299
Copy link

Decrypted string is returned as b'text' which should be decoded to utf-8.

@baryal1299
KMS lookups give values $VAL wrapped as "b'$VAL'" when using python 3
a675dc2 
Decrypted string is returned as b'text' which should be decoded to utf-8.
@baryal1299 baryal1299 mentioned this pull request Sep 8, 2020
Closed
troyready
troyready requested changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@troyready troyready left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution here. I think the decoding needs to be gated on python 3, e.g. after if sys.version_info[0] > 2: condition

@hauntingEcho hauntingEcho mentioned this pull request Sep 14, 2020
Merged
@hauntingEcho
Copy link
Contributor

This may have been superceded by #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready troyready requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baryal1299 @hauntingEcho @troyready