Cb17 fixup #640
Open
Cb17 fixup #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2017 00:55
This is the network stack which containers an ECS cluster with ALB and ElasticSearch cluster. This also leverages the new cross-stack functionality
This is the app stack which contains an ECS Task Definition that attaches to an ECS cluster and a CloudWatch Logs group which streams logs to an ElasticSearch cluster from the network template. This also leverages the new cross-stack functionality
|
@lil-cain The tests for this are failing - any chance you can take a look at it? |
|
Sorry - been out on paternity leave. Will come back and sort out what's up
with the python 2 tests in the next fortnight or so.
…On Thu, 26 Jan 2017, 17:29 Michael Barrett, ***@***.***> wrote:
@lil-cain <https://github.com/lil-cain> The tests for this are failing -
any chance you can take a look at it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#640 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADys0o9eM4TCb833qoD7LjTNnWw--bCwks5rWNfXgaJpZM4LhPY1>
.
|
|
Thanks @lil-cain ! Good luck with your paternity leave :) |
|
Hey - just been looking at this again - it looks like there's an issue in template_generator._generate_autoscaling_metadata, in that this assumes that AWS::CloudFormation::Init will always have a single key (config). From the cloud formation docs though, you can have multiple keys in this dict, with only configsets being required in this case. Am I barking up entirely the wrong tree with this? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for changes requested for #570
I've had to remove the lambda used to input logs to elasticsearch, as it relied on a javascript file that's not in the PR. There's also some other changes required to make the troposphere templates actually compile - Exports were a dictionary, so I modified them to be a troposphere.export
I haven't reviewed the actually generated templates to check they make sense :-)