feat(hz): optional filed parse for client #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1177 +/- ##
===========================================
+ Coverage 82.61% 82.86% +0.25%
===========================================
Files 123 124 +1
Lines 11455 11695 +240
===========================================
+ Hits 9463 9691 +228
- Misses 1419 1431 +12
Partials 573 573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Duslia
reviewed
Sep 5, 2024
| @@ -194,6 +194,9 @@ func Init() *cli.App { | |||
| handlerByMethod := cli.BoolFlag{Name: "handler_by_method", Usage: "Generate a separate handler file for each method.", Destination: &globalArgs.HandlerByMethod} | |||
| trimGoPackage := cli.StringFlag{Name: "trim_gopackage", Aliases: []string{"trim_pkg"}, Usage: "Trim the prefix of go_package for protobuf.", Destination: &globalArgs.TrimGoPackage} | |||
|
|
|||
| // client flag | |||
| enableClientOptionalFlag := cli.BoolFlag{Name: "enable_optional", Usage: "Optional field do not transfer for thrift if not set.(Only works for query tag)", Destination: &globalArgs.EnableClientOptional} | |||
There was a problem hiding this comment.
这个不仅仅是 query 场景，可能后续的 form 场景也会有；等用户有需求的时候我再form 场景也给加上
There was a problem hiding this comment.
我这次都给加上吧，要不之后再加就不好加了
welkeyever
reviewed
Sep 5, 2024
| @@ -194,6 +194,9 @@ func Init() *cli.App { | |||
| handlerByMethod := cli.BoolFlag{Name: "handler_by_method", Usage: "Generate a separate handler file for each method.", Destination: &globalArgs.HandlerByMethod} | |||
| trimGoPackage := cli.StringFlag{Name: "trim_gopackage", Aliases: []string{"trim_pkg"}, Usage: "Trim the prefix of go_package for protobuf.", Destination: &globalArgs.TrimGoPackage} | |||
|
|
|||
| // client flag | |||
| enableClientOptionalFlag := cli.BoolFlag{Name: "enable_optional", Usage: "Optional field do not transfer for thrift if not set.(Only works for query tag)", Destination: &globalArgs.EnableClientOptional} | |||
There was a problem hiding this comment.
flag 的名字和描述里也说明下是 Client 的？另外这个行为默认enable 有啥问题吗
There was a problem hiding this comment.
ok。这个会对之前的行为有影响，导致之前传值现在不传值；目前来看，有这个需求的用户还是比较少的，所以还是单独搞一个 flag 出来
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
针对 hz client，对 optional 字段进行处理，如果用户不设置对应值，则不传这个值
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: optional filed parse for client
zh(optional):
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: