Significant rewrite of Abi.Encode #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with some bugfixes + several unit tests (generated from ethersjs AbiEncoder behaviour) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I've been toying a bit with web3 & Elm.
It seems to me that the abi encoder is significantly broken when it comes to complex structs, or encoding dynamic lists that themselves contains nested pointer indirections.
I've rewritten the whole encoder, and added some tests.
Tests have either been created from ethers.js AbiEncdoer output, or from calls expected by our smartcontracts (I've deployed an app in prod that uses this encoder... works like a charm)
Given that this is a rewrite, I wont mind at all if you're not willing to merge this, though :) That's up to you !
nb: I've also exposed the
structfunction from your Abi.Decode, which works well for me, despite your frightening comment !nb2: I'm new to Elm, so please forgive any weird coding style !
Cheers & thanks for this lib !