[fixed] plug-in conflict with i18n
#167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmode
changed the title
i18n
|
I have tested it!! In my local this fix working fine. @cmfcmf please could you review it once? |
cmfcmf
added a commit
that referenced
this pull request
Feb 25, 2023
|
Thanks a lot for looking into this! I think I found a slightly better solution, namely to no longer generate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with Generated.js (Which is automatically generated by servers side)
fixes: #163 ,starcoinorg/starcoin-cookbook#164
after:
before:
Need a review. if I'm wrong anywhere please provide suggestions. I'll implement asap