Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended wiring with all combined modules #6

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

aehart
Copy link
Contributor

@aehart aehart commented Oct 8, 2024

This PR adds a new wiring for the "extended" (i.e., prompt + displaced) tracking. The wiring uses the newer "combined" processing modules consistently, which is not the case for the existing wirings.

Once this is merged, we plan to make this the default wiring for extended tracking in cms-sw/cmssw#45974.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

A new Pull Request was created by @aehart for branch master.

@aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

cms-bot internal usage

@aloeliger
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0aa3/42047/summary.html
COMMIT: 5426aad
CMSSW: CMSSW_14_2_X_2024-10-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/6/42047/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0aa3/42047/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d0aa3/42047/git-merge-result

Comparison Summary

Summary:

@tomalin
Copy link

tomalin commented Oct 12, 2024

This PR adds a new wiring for the "extended" (i.e., prompt + displaced) tracking. The wiring uses the newer "combined" processing modules consistently, which is not the case for the existing wirings.

Once this is merged, we plan to make this the default wiring for extended tracking in cms-sw/cmssw#45974.

This PR to cms-data should go into the same CMSSW release as cms-sw/cmssw#46360 , as they depend on each other. (PR46360 has replaced PR45974, which has been closed).

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmssw#46360, please check if they should be merged together

@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge
Assuming L1 sig, since they signed the PR which relies on this PR

@cmsbuild cmsbuild merged commit 05518d6 into cms-data:master Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants