Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set track word before running TQ MVA #1254

Open
wants to merge 2 commits into
base: phase2-l1t-integration-14_0_0_pre3
Choose a base branch
from

Conversation

cgsavard
Copy link

@cgsavard cgsavard commented May 2, 2024

PR description:

The TQ MVA variable is currently outputting useless information starting in CMSSW 14X because the inputs to the MVA take in some of the track word information which has been changed to be set after the MVA is calculated. Therefore, the MVA is getting inputs of 0 for the track word variables. The fix simply moves the setting of the track word to before the TQ MVA calculation again, while also having a setting after the MVA calculation to set the MVA variable in the track word.

This fix will also need to be made in central CMSSW as the bug can also be found there.

Note: It is perhaps not the most elegant solution to set the track word both before and after the MVA calculation. This current fix should be implemented ASAP as many GTT objects rely on the MVA and so they currently are getting a wrong value and it's probably hurting performance. I am chatting with the L1Tk group to discuss having a separate setter for the MVA variables in the TTTrack and track word classes and will implement that solution when we have decided what is best.

PR validation:

All code checks have been run and the fix gives the desired behavior.

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 3 files that did not meet formatting requirements:

  • L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
  • L1Trigger/Phase2L1GMT/interface/TPSLUTs.h
  • L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTFwdMuonTranslator.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b runtests

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR!

Info Value
return code 1
command eval scramv1 runtime -sh && runTheMatrix.py --what upgrade -l 26834.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants