Set track word before running TQ MVA #1254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The TQ MVA variable is currently outputting useless information starting in CMSSW 14X because the inputs to the MVA take in some of the track word information which has been changed to be set after the MVA is calculated. Therefore, the MVA is getting inputs of 0 for the track word variables. The fix simply moves the setting of the track word to before the TQ MVA calculation again, while also having a setting after the MVA calculation to set the MVA variable in the track word.
This fix will also need to be made in central CMSSW as the bug can also be found there.
Note: It is perhaps not the most elegant solution to set the track word both before and after the MVA calculation. This current fix should be implemented ASAP as many GTT objects rely on the MVA and so they currently are getting a wrong value and it's probably hurting performance. I am chatting with the L1Tk group to discuss having a separate setter for the MVA variables in the TTTrack and track word classes and will implement that solution when we have decided what is best.
PR validation:
All code checks have been run and the fix gives the desired behavior.