EMTF new LCT coordinate conversion LUTs

[abrinke1]

As detailed here [1], the phi coordinates computed in EMTF via the Primitive Conversion Look-Up Tables ("PC LUTs") are significantly displaced from the true coordinates, due to detector mis-alignment effects. EMTF will be loading new PC LUTs reflecting the real CMS geometry, and thus new LUTs and modifications to the emulator are needed to preserve data-emulator agreement.

The new LUTs are being PR-ed separately here:

This update is urgently needed for the DQM.

Best regards,
Andrew for the EMTF team

[1] https://indico.cern.ch/event/758694/contributions/3146645/subcontributions/263903/attachments/1719883/2776101/2018_09_20_EMTF_alignment.pdf

[cmsbuild]

A new Pull Request was created by @abrinke1 for CMSSW_10_2_X.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from EMTF new LCT coordinate conversion LUTs #24766

[abrinke1]

The new LUTs are being PR-ed separately here: cms-l1t-offline/L1Trigger-L1TMuon#9

[abrinke1]

For central cms-data, the LUT PR is actually here: cms-data/L1Trigger-L1TMuon#16

[cmsbuild]

Pull request #24617 was updated. @nsmith-, @rekovic, @cmsbuild, @thomreis can you please check and sign again.

[thomreis]

please test with cms-data/L1Trigger-L1TMuon#16

[thomreis]

That did not work. @rekovic do you know how to lunch the tests properly?

[threus]

@thomreis if this is only a temporary PR until cms-data/L1Trigger-L1TMuon#16 gets merged, maybe there is no need to run these tests. Just make sure the links work (see my email response) and if all is fine, @abrinke1 can close this PR, we'll take it to online DQM. Once L1TMuon#16 is merged, we'll switch to #24617

[thomreis]

Hi @threus
The data PR got merged now.

[threus]

@thomreis great. But we'll need a patch release with the data PR, only then we can use #24617 in online DQM. Until then, we'll use this PR (once it works). Apologies, I was not clear in my previous comment.

[thomreis]

please test with cms-sw/cmsdist#4356

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4356
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30649/console

[smuzaffar]

@thomreis , this PR is for 10.2.X while cmsdist PR is for 10.3.X. Please first the cmsdist PR for 10.3.X and then we can backport it to 10.2.

[smuzaffar]

please test with cms-sw/cmsdist#4378

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4378
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30680/console

[fabiocos]

@abrinke1 is this the backport of something? Otherwise please propose it first in master

[cmsbuild]

+1
Tested at: 1de679a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24617/30680/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24617/30680/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2986766
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2986574
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[abrinke1]

@fabiocos , @rekovic ,
PR to 10_3_X can be found here: #24766
Cheers,
Andrew

[thomreis]

backport of #24766

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[thomreis]

Hi @abrinke1
since 10_2 is not used anymore this PR can probably be closed.