Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website to reflect correct meeting time #607

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

lianmakesthings
Copy link
Collaborator

We changed the cadence of the meeting, this has not been updated on the website yet.

I made an effort to translate to Chinese, Japanese and Korean with the help of Google translate and my very limited understanding of these languages. Would appreciate a review by fluent speakers 🙏 @node @hhiroshell @Eeap

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 86dda07
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/660ea9ed65fe3300089966a7
😎 Deploy Preview https://deploy-preview-607--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Copy link

github-actions bot commented Apr 4, 2024

Action Required

You are adding or updating English content so please take the following actions for other languages.

  • If you add new content under website/content/en or targets of the symbolic links in the same directory, please replicate it in the corresponding directories of all other languages. (e.g. If you create website/content/en/blog/new-post.md, you should copy it to website/content/ja/blog/new-post.md, etc.)
  • If you update the content in the same location, please perform the following actions for the corresponding content in other languages.
    • If the content has not been translated yet, replace the files with the updated English version.
    • If the content has already been translated, include a note suggesting that users check the English page for the most recent updates.

Copy link
Contributor

@hhiroshell hhiroshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lianmakesthings
The Japanese translation looks fine to me!👍

@hhiroshell
Copy link
Contributor

hhiroshell commented Apr 5, 2024

Anyway, I'm happy to see the GitHub action working fine. 😄

@Eeap
Copy link
Contributor

Eeap commented Apr 5, 2024

If "Every two weeks on Wednesday" means 2nd and 4th week, it looks good to me :).
Also, it looks better word, if you change "2주마다" with "격주".

@lianmakesthings
Copy link
Collaborator Author

If "Every two weeks on Wednesday" means 2nd and 4th week, it looks good to me :)

@Eeap Unfortuntely, not necessarily. It just means in a 2-week cadence, it could be 1st and 3rd. What would be the correct translation for that?

@Eeap
Copy link
Contributor

Eeap commented Apr 5, 2024

If "Every two weeks on Wednesday" means 2nd and 4th week, it looks good to me :)

@Eeap Unfortuntely, not necessarily. It just means in a 2-week cadence, it could be 1st and 3rd. What would be the correct translation for that?

Then "2주마다" is ok, but it is not natural with following words ("2주마다 수요일" is not natural). So"격주" instead of "2주마다" is better to understand for Korean.
Thank you :)

Copy link
Contributor

@angellk angellk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@angellk angellk merged commit 571bdf3 into main Apr 10, 2024
6 checks passed
@angellk angellk deleted the update_meeting_times branch April 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants