Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input 의 useId 를 react 제공 함수로 변경했다 #36

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Input 의 useId 를 react 제공 함수로 변경했다 #36

merged 3 commits into from
Oct 12, 2023

Conversation

healtheloper
Copy link
Member

📌 PR 설명

  • co-design/hooks 에서 제공하고 있는 useId 가 리렌더링을 일으켜 focus 가 풀리는 경우가 있어 react 제공 함수로 변경했습니다.
스크린샷 2023-10-12 오후 6 51 20 스크린샷 2023-10-12 오후 6 52 23

@healtheloper healtheloper self-assigned this Oct 12, 2023
@healtheloper healtheloper added the 개선 기능 혹은 비기능적인 요소를 개선합니다. label Oct 12, 2023
@kciter
Copy link
Member

kciter commented Oct 12, 2023

머지하셔도 괜찮습니다.

@healtheloper healtheloper merged commit 87d857f into main Oct 12, 2023
2 of 3 checks passed
@healtheloper healtheloper deleted the park/input-useId branch October 12, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kciter kciter kciter approved these changes

@StellaKim1230 StellaKim1230 Awaiting requested review from StellaKim1230

Assignees

@healtheloper healtheloper

Labels
개선 기능 혹은 비기능적인 요소를 개선합니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@healtheloper @kciter