Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer 의 Transition 이벤트시 외부함수를 주입할수 있도록 변경했다 #44

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

healtheloper
Copy link
Member

📌 PR 설명

  • Transition 이벤트 시 사용할 수 있는 prop 을 추가했습니다.

@healtheloper healtheloper added the 개선 기능 혹은 비기능적인 요소를 개선합니다. label Nov 13, 2023
@healtheloper healtheloper self-assigned this Nov 13, 2023
Comment on lines 154 to 156
onExit={() => {
if (onExit) onExit();
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onExit={onExit}와 같은 형태로 넣으면 onExitundefined일 때 어차피 실행이 안될 것 같은데 if를 사용한 이유가 있을까요?

Copy link
Member Author

@healtheloper healtheloper Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kciter undefiend 인 경우 내부 로직에서 undefiend 임에도 함수로 실행시키는 로직이 있다면 undefined is not function 타입 에러가 발생할 수 있을 것 같아 한번 조건문으로 감쌌는데, 내부 로직을 다시 파악해보니 typeof function 로 분기처리하고 있어서 말씀하신 코드로 변경하겠습니다

@kciter kciter merged commit 0e58531 into main Nov 13, 2023
1 check failed
@kciter kciter deleted the park/drawer-events branch November 13, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
개선 기능 혹은 비기능적인 요소를 개선합니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants