-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
65899: util/caller: simplify, make the code compatible with bazel r=tbg,rickystewart a=knz Fixes #61913. The bazel sandbox places source files into a different directory structure than a regular `go build` or `go get`. We need to accommodate for this. Additionally, this change converts the code to use `runtime.CallersFrames`, which simplifies the extraction of the crdb package name, which in turns greatly simplifies the computation of the `defaultRE` regular expression. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
- Loading branch information
Showing
3 changed files
with
124 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,5 @@ go_test( | |
"resolver_test.go", | ||
], | ||
embed = [":caller"], | ||
tags = ["broken_in_bazel"], | ||
deps = ["//pkg/util/log"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters